test: add regression test for indexer cursor advancing past failed ev… - #1070
Merged
ogazboiz merged 1 commit intoAug 6, 2026
Merged
Conversation
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
the core worker fix is right: the hasError flag freezing the cursor at the last pre-failure event and skipping the latestCursor fallback on error is exactly what #846 needs, and the regression test is solid. but the PR is bigger than its title:
- drop the unrelated changes: contracts test.rs formatting, the create-stream-content.tsx StrKey import rewrite, and the test-env retry knobs in useIncomingStreams.ts (the last collides with #996 and #1001).
- restore the removed toHaveBeenCalledTimes(1) assertion in pause-resume.regression.test.ts, or explain why it is now wrong; as it stands the #804 guard got weaker.
- rebase and re-run now that main is green.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
extolkom
force-pushed
the
test/846-indexer-per-event-failure-cursor
branch
from
August 6, 2026 22:56
c33f758 to
3f33038
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #846
Added regression test
cursor_does_not_advance_past_failed_event_in_mixed_batchtobackend/tests/soroban-event-worker.test.ts.main(AssertionError: expected 'cursor-event-3' not to be 'cursor-event-3').test/846-indexer-per-event-failure-cursor.